-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Namespace scoped NetworkPolicy CRD #775
Conversation
Thanks for your PR. The following commands are available:
These commands can only be run by members of the vmware-tanzu organization. |
Add new CRD yamls only when explicitly set.
Move ExternalEndpoint to core group.
Address comments.
d6b52dd
to
1ed1e74
Compare
- Nameport.protocol is no longer a pointer --> consistent with k8s core.servicePort - ExternalEndPoint.ip is a string ---> so it is readable to end user. - Add "omitempty" to all fields ---> we potentially can have some fields unset. - added webhook methods ---> allows ExternalEntity to hookup to webhook service.
/test-all |
/test-e2e |
/test-windows-conformance |
* Add API types for Namespaced Antrea NetworkPolicy * Update priority to float64 Add new CRD yamls only when explicitly set. * Update apigroup for ExternalEndpoint CRD Move ExternalEndpoint to core group. * Fix name mismatch for externalNode field * Move security and core group to v1alpha1 Address comments. * Minor patches to ANP CRD types - Nameport.protocol is no longer a pointer --> consistent with k8s core.servicePort - ExternalEndPoint.ip is a string ---> so it is readable to end user. - Add "omitempty" to all fields ---> we potentially can have some fields unset. - added webhook methods ---> allows ExternalEntity to hookup to webhook service. Co-authored-by: Abhishek Raut <rauta@vmware.com> Co-authored-by: Su Wang <suw@vmware.com>
* Add API types for Namespaced Antrea NetworkPolicy * Update priority to float64 Add new CRD yamls only when explicitly set. * Update apigroup for ExternalEndpoint CRD Move ExternalEndpoint to core group. * Fix name mismatch for externalNode field * Move security and core group to v1alpha1 Address comments. * Minor patches to ANP CRD types - Nameport.protocol is no longer a pointer --> consistent with k8s core.servicePort - ExternalEndPoint.ip is a string ---> so it is readable to end user. - Add "omitempty" to all fields ---> we potentially can have some fields unset. - added webhook methods ---> allows ExternalEntity to hookup to webhook service. Co-authored-by: Abhishek Raut <rauta@vmware.com> Co-authored-by: Su Wang <suw@vmware.com>
The scope of this PR is as follows:
OpenAPIv3 validation schema to validate NP spec and ensure AppliedTo and Priority (1-10000) fields are mandatory